Commit a7ffdbe2 authored by Jaegeuk Kim's avatar Jaegeuk Kim
Browse files

f2fs: expand counting dirty pages in the inode page cache 



Previously f2fs only counts dirty dentry pages, but there is no reason not to
expand the scope.

This patch changes the names on the management of dirty pages and to count
dirty pages in each inode info as well.

Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 2403c155

fs/f2fs/checkpoint.c

+11 −5
Original line number Diff line number Diff line
@@ -627,27 +627,33 @@ static int __add_dirty_inode(struct inode *inode, struct dir_inode_entry *new) 
	return 0;

}



void set_dirty_dir_page(struct inode *inode, struct page *page)

void update_dirty_page(struct inode *inode, struct page *page)

{

	struct f2fs_sb_info *sbi = F2FS_I_SB(inode);

	struct dir_inode_entry *new;

	int ret = 0;



	if (!S_ISDIR(inode->i_mode))

	if (!S_ISDIR(inode->i_mode) && !S_ISREG(inode->i_mode))

		return;



	if (!S_ISDIR(inode->i_mode)) {

		inode_inc_dirty_pages(inode);

		goto out;

	}



	new = f2fs_kmem_cache_alloc(inode_entry_slab, GFP_NOFS);

	new->inode = inode;

	INIT_LIST_HEAD(&new->list);



	spin_lock(&sbi->dir_inode_lock);

	ret = __add_dirty_inode(inode, new);

	inode_inc_dirty_dents(inode);

	SetPagePrivate(page);

	inode_inc_dirty_pages(inode);

	spin_unlock(&sbi->dir_inode_lock);



	if (ret)

		kmem_cache_free(inode_entry_slab, new);

out:

	SetPagePrivate(page);

}



void add_dirty_dir_inode(struct inode *inode)
@@ -677,7 +683,7 @@ void remove_dirty_dir_inode(struct inode *inode) 
		return;



	spin_lock(&sbi->dir_inode_lock);

	if (get_dirty_dents(inode) ||

	if (get_dirty_pages(inode) ||

			!is_inode_flag_set(F2FS_I(inode), FI_DIRTY_DIR)) {

		spin_unlock(&sbi->dir_inode_lock);

		return;

fs/f2fs/data.c

+10 −6
Original line number Diff line number Diff line
@@ -843,7 +843,7 @@ write: 
	if (unlikely(f2fs_cp_error(sbi))) {

		SetPageError(page);

		unlock_page(page);

		return 0;

		goto out;

	}



	if (!wbc->for_reclaim)
@@ -863,7 +863,7 @@ done: 


	clear_cold_data(page);

out:

	inode_dec_dirty_dents(inode);

	inode_dec_dirty_pages(inode);

	unlock_page(page);

	if (need_balance_fs)

		f2fs_balance_fs(sbi);
@@ -901,7 +901,7 @@ static int f2fs_write_data_pages(struct address_space *mapping, 
		return 0;



	if (S_ISDIR(inode->i_mode) && wbc->sync_mode == WB_SYNC_NONE &&

			get_dirty_dents(inode) < nr_pages_to_skip(sbi, DATA) &&

			get_dirty_pages(inode) < nr_pages_to_skip(sbi, DATA) &&

			available_free_memory(sbi, DIRTY_DENTS))

		goto skip_write;
@@ -923,7 +923,7 @@ static int f2fs_write_data_pages(struct address_space *mapping, 
	return ret;



skip_write:

	wbc->pages_skipped += get_dirty_dents(inode);

	wbc->pages_skipped += get_dirty_pages(inode);

	return 0;

}
@@ -1107,8 +1107,12 @@ static void f2fs_invalidate_data_page(struct page *page, unsigned int offset, 
				      unsigned int length)

{

	struct inode *inode = page->mapping->host;



	if (offset % PAGE_CACHE_SIZE || length != PAGE_CACHE_SIZE)

		return;



	if (PageDirty(page))

		inode_dec_dirty_dents(inode);

		inode_dec_dirty_pages(inode);

	ClearPagePrivate(page);

}
@@ -1130,7 +1134,7 @@ static int f2fs_set_data_page_dirty(struct page *page) 


	if (!PageDirty(page)) {

		__set_page_dirty_nobuffers(page);

		set_dirty_dir_page(inode, page);

		update_dirty_page(inode, page);

		return 1;

	}

	return 0;

fs/f2fs/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -618,7 +618,7 @@ void f2fs_delete_entry(struct f2fs_dir_entry *dentry, struct page *page, 
		truncate_hole(dir, page->index, page->index + 1);

		clear_page_dirty_for_io(page);

		ClearPageUptodate(page);

		inode_dec_dirty_dents(dir);

		inode_dec_dirty_pages(dir);

	}

	f2fs_put_page(page, 1);

}

fs/f2fs/f2fs.h

+14 −11
Original line number Diff line number Diff line
@@ -237,7 +237,7 @@ struct f2fs_inode_info { 
	/* Use below internally in f2fs*/

	unsigned long flags;		/* use to pass per-file flags */

	struct rw_semaphore i_sem;	/* protect fi info */

	atomic_t dirty_dents;		/* # of dirty dentry pages */

	atomic_t dirty_pages;		/* # of dirty pages */

	f2fs_hash_t chash;		/* hash value of given file name */

	unsigned int clevel;		/* maximum level of given file name */

	nid_t i_xattr_nid;		/* node id that contains xattrs */
@@ -747,10 +747,11 @@ static inline void inc_page_count(struct f2fs_sb_info *sbi, int count_type) 
	F2FS_SET_SB_DIRT(sbi);

}



static inline void inode_inc_dirty_dents(struct inode *inode)

static inline void inode_inc_dirty_pages(struct inode *inode)

{

	atomic_inc(&F2FS_I(inode)->dirty_pages);

	if (S_ISDIR(inode->i_mode))

		inc_page_count(F2FS_I_SB(inode), F2FS_DIRTY_DENTS);

	atomic_inc(&F2FS_I(inode)->dirty_dents);

}



static inline void dec_page_count(struct f2fs_sb_info *sbi, int count_type)
@@ -758,13 +759,15 @@ static inline void dec_page_count(struct f2fs_sb_info *sbi, int count_type) 
	atomic_dec(&sbi->nr_pages[count_type]);

}



static inline void inode_dec_dirty_dents(struct inode *inode)

static inline void inode_dec_dirty_pages(struct inode *inode)

{

	if (!S_ISDIR(inode->i_mode))

	if (!S_ISDIR(inode->i_mode) && !S_ISREG(inode->i_mode))

		return;



	atomic_dec(&F2FS_I(inode)->dirty_pages);



	if (S_ISDIR(inode->i_mode))

		dec_page_count(F2FS_I_SB(inode), F2FS_DIRTY_DENTS);

	atomic_dec(&F2FS_I(inode)->dirty_dents);

}



static inline int get_pages(struct f2fs_sb_info *sbi, int count_type)
@@ -772,9 +775,9 @@ static inline int get_pages(struct f2fs_sb_info *sbi, int count_type) 
	return atomic_read(&sbi->nr_pages[count_type]);

}



static inline int get_dirty_dents(struct inode *inode)

static inline int get_dirty_pages(struct inode *inode)

{

	return atomic_read(&F2FS_I(inode)->dirty_dents);

	return atomic_read(&F2FS_I(inode)->dirty_pages);

}



static inline int get_blocktype_secs(struct f2fs_sb_info *sbi, int block_type)
@@ -1302,7 +1305,7 @@ void add_orphan_inode(struct f2fs_sb_info *, nid_t); 
void remove_orphan_inode(struct f2fs_sb_info *, nid_t);

void recover_orphan_inodes(struct f2fs_sb_info *);

int get_valid_checkpoint(struct f2fs_sb_info *);

void set_dirty_dir_page(struct inode *, struct page *);

void update_dirty_page(struct inode *, struct page *);

void add_dirty_dir_inode(struct inode *);

void remove_dirty_dir_inode(struct inode *);

void sync_dirty_dir_inodes(struct f2fs_sb_info *);

fs/f2fs/gc.c

+1 −1
Original line number Diff line number Diff line
@@ -537,7 +537,7 @@ static void move_data_page(struct inode *inode, struct page *page, int gc_type) 
		f2fs_wait_on_page_writeback(page, DATA);



		if (clear_page_dirty_for_io(page))

			inode_dec_dirty_dents(inode);

			inode_dec_dirty_pages(inode);

		set_cold_data(page);

		do_write_data_page(page, &fio);

		clear_cold_data(page);

CRA Git | Maintained and supported by SUSTech CRA and CCSE