Commit a7faa8dc authored Feb 09, 2008 by Takashi Yamamoto Committed by Paul Mackerras Feb 14, 2008

[POWERPC] PS3: Fix setting bookmark in logical performance monitor



Fix the ps3_set_bookmark() routine of the PS3 logical performance
monitor driver.

To properly set a performance monitor bookmark the Cell processor
requires no instruction branches near the setting of the bookmark
SPR.  Testing showed that the use of the db10cyc instruction did
not work correctly.  This change replaces the db10cyc instruction
with 10 nop instructions.

Signed-off-by: Takashi Yamamoto <TakashiA.Yamamoto@jp.sony.com>
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>

parent 79ccd1be

drivers/ps3/ps3-lpm.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -181,9 +181,9 @@ void ps3_set_bookmark(u64 bookmark)
		* includes cycles before the call.
		*/

		asm volatile("or 29, 29, 29;"); /* db10cyc */
		asm volatile("nop;nop;nop;nop;nop;nop;nop;nop;nop;");
		mtspr(SPRN_BKMK, bookmark);
		asm volatile("or 29, 29, 29;"); /* db10cyc */
		asm volatile("nop;nop;nop;nop;nop;nop;nop;nop;nop;");
		}
		EXPORT_SYMBOL_GPL(ps3_set_bookmark);

Admin message