Commit a7e1d98f authored Jan 23, 2014 by Paul Bolle Committed by Linus Torvalds Jan 23, 2014

headers_check: special case seqbuf_dump()

"make headers_check" warns about soundcard.h for (at least) five years
now:
    [...]/usr/include/linux/soundcard.h:1054: userspace cannot reference function or variable defined in the kernel

We're apparently stuck with providing OSSlib-3.8 compatibility, so let's
special case this declaration just to silence it.

Notes:

0) Support for OSSlib post 3.8 was already removed in commit 43a99076
   ("sound: Remove OSSlib stuff from linux/soundcard.h").  Five years have
   passed since that commit: do people still care about OSSlib-3.8?  If
   not, quite a bit of code could be remove from soundcard.h (and probably
   ultrasound.h).

2) By the way, what is actually meant by:
    It is no longer possible to actually link against OSSlib with this
    header, but we still provide these macros for programs using them.

Doesn't that mean compatibility to OSSlib isn't even useful?

3) Anyhow, a previous discussion soundcard.h, which led to that commit,
   starts at https://lkml.org/lkml/2009/1/20/349

 .

4) And, yes, I sneaked in a whitespace fix.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Cc: Takashi Iwai <tiwai@suse.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Cc: Michal Marek <mmarek@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 59d42cd4

scripts/headers_check.pl

+5 −1

Original line number	Diff line number	Diff line
		@@ -65,6 +65,10 @@ sub check_include

		sub check_declarations
		{
		# soundcard.h is what it is
		if ($line =~ m/^void seqbuf_dump$void$;/) {
		return;
		}
		if ($line =~ m/^(\s*extern\|unsigned\|char\|short\|int\|long\|void)\b/) {
		printf STDERR "$filename:$lineno: " .
		"userspace cannot reference function or " .

Admin message