ALSA: pci: Remove empty init and exit (a7da09fe) · Commits · 戴 / test

For a sake of code simplification, remove the init and the exit entries that do nothing. Notes for readers: actually it's OK to remove *both* init and exit, but not OK to remove the exit entry. By removing only the exit while keeping init, the module becomes permanently loaded; i.e. you cannot unload it any longer! Signed-off-by:

Takashi Iwai <tiwai@suse.de>

sound/pci/ac97/ac97_codec.c

+0 −16

Original line number	Diff line number	Diff line
		@@ -2941,19 +2941,3 @@ int snd_ac97_tune_hardware(struct snd_ac97 *ac97,
		}

		EXPORT_SYMBOL(snd_ac97_tune_hardware);

		/*
		* INIT part
		*/

		static int __init alsa_ac97_init(void)
		{
		return 0;
		}

		static void __exit alsa_ac97_exit(void)
		{
		}

		module_init(alsa_ac97_init)
		module_exit(alsa_ac97_exit)

sound/pci/ice1712/ak4xxx.c

+0 −12

Original line number	Diff line number	Diff line
		@@ -179,18 +179,6 @@ int snd_ice1712_akm4xxx_build_controls(struct snd_ice1712 *ice)
		return 0;
		}

		static int __init alsa_ice1712_akm4xxx_module_init(void)
		{
		return 0;
		}

		static void __exit alsa_ice1712_akm4xxx_module_exit(void)
		{
		}

		module_init(alsa_ice1712_akm4xxx_module_init)
		module_exit(alsa_ice1712_akm4xxx_module_exit)

		EXPORT_SYMBOL(snd_ice1712_akm4xxx_init);
		EXPORT_SYMBOL(snd_ice1712_akm4xxx_free);
		EXPORT_SYMBOL(snd_ice1712_akm4xxx_build_controls);

Admin message