Commit a7d5b76d authored Oct 22, 2011 by Clemens Buchacher Committed by David S. Miller Oct 24, 2011

jme: fix irq storm after suspend/resume

If the device is down during suspend/resume, interrupts are enabled
without a registered interrupt handler, causing a storm of
unhandled interrupts until the IRQ is disabled because "nobody
cared".

Instead, check that the device is up before touching it in the
suspend/resume code.

Fixes https://bugzilla.kernel.org/show_bug.cgi?id=39112



Helped-by: Adrian Chadd <adrian@freebsd.org>
Helped-by: Mohammed Shafi <shafi.wireless@gmail.com>
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7cc9150e

drivers/net/jme.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -3131,6 +3131,9 @@ jme_suspend(struct device *dev)
		struct net_device *netdev = pci_get_drvdata(pdev);
		struct jme_adapter *jme = netdev_priv(netdev);

		if (!netif_running(netdev))
		return 0;

		atomic_dec(&jme->link_changing);

		netif_device_detach(netdev);
		@@ -3171,6 +3174,9 @@ jme_resume(struct device *dev)
		struct net_device *netdev = pci_get_drvdata(pdev);
		struct jme_adapter *jme = netdev_priv(netdev);

		if (!netif_running(netdev))
		return 0;

		jme_clear_pm(jme);
		jme_phy_on(jme);
		if (test_bit(JME_FLAG_SSET, &jme->flags))

Admin message