Commit a7c9df04 authored by Alex Dewar's avatar Alex Dewar Committed by Al Viro
Browse files

fs: omfs: use kmemdup() rather than kmalloc+memcpy 



Issue identified with Coccinelle.

Signed-off-by: default avatarAlex Dewar <alex.dewar90@gmail.com>
Acked-by: default avatarBob Copeland <me@bobcopeland.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 6d1349c7

fs/omfs/inode.c

+1 −2
Original line number Diff line number Diff line
@@ -362,12 +362,11 @@ static int omfs_get_imap(struct super_block *sb) 
		bh = sb_bread(sb, block++);

		if (!bh)

			goto nomem_free;

		*ptr = kmalloc(sb->s_blocksize, GFP_KERNEL);

		*ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL);

		if (!*ptr) {

			brelse(bh);

			goto nomem_free;

		}

		memcpy(*ptr, bh->b_data, sb->s_blocksize);

		if (count < sb->s_blocksize)

			memset((void *)*ptr + count, 0xff,

				sb->s_blocksize - count);

CRA Git | Maintained and supported by SUSTech CRA and CCSE