ASoC: soc-core: remove dai->driver NULL check (a7c439d6) · Commits · 戴 / test

It is strange if it has "dai" but doesn't have "dai->driver". And more over "dai->driver->xxx" is used everywhere without "dai->driver" pointer NULL checking. It got Oops already if "dai->driver" was NULL. Let's remove un-needed "dai->driver" NULL check. Signed-off-by:

Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/soc-core.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -2519,8 +2519,6 @@ EXPORT_SYMBOL_GPL(snd_soc_dai_set_bclk_ratio);
		*/
		int snd_soc_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
		{
		if (dai->driver == NULL)
		return -EINVAL;
		if (dai->driver->ops->set_fmt == NULL)
		return -ENOTSUPP;
		return dai->driver->ops->set_fmt(dai, fmt);
		@@ -2667,9 +2665,6 @@ EXPORT_SYMBOL_GPL(snd_soc_dai_set_tristate);
		int snd_soc_dai_digital_mute(struct snd_soc_dai *dai, int mute,
		int direction)
		{
		if (!dai->driver)
		return -ENOTSUPP;

		if (dai->driver->ops->mute_stream)
		return dai->driver->ops->mute_stream(dai, mute, direction);
		else if (direction == SNDRV_PCM_STREAM_PLAYBACK &&

Admin message