fsldma: use PCI Read Multiple command (a7aea373) · Commits · 戴 / test

By default, the Freescale 83xx DMA controller uses the PCI Read Line command when reading data over the PCI bus. Setting the controller to use the PCI Read Multiple command instead allows the controller to read much larger bursts of data, which provides a drastic speed increase. The slowdown due to using PCI Read Line was only observed when a PCI-to-PCI bridge was between the devices trying to communicate. A simple test driver showed an increase from 4MB/sec to 116MB/sec when performing DMA over the PCI bus. Using DMA to transfer between blocks of local SDRAM showed no change in performance with this patch. The dmatest driver was also used to verify the correctness of the transfers, and showed no errors. Signed-off-by:

Ira W. Snyder <iws@ovro.caltech.edu> Acked-by:

Timur Tabi <timur@freescale.com> Acked-by:

Kumar Gala <galak@kernel.crashing.org> Signed-off-by:

Dan Williams <dan.j.williams@intel.com>

drivers/dma/fsldma.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -12,6 +12,11 @@
		* also fit for MPC8560, MPC8555, MPC8548, MPC8641, and etc.
		* The support for MPC8349 DMA contorller is also added.
		*
		* This driver instructs the DMA controller to issue the PCI Read Multiple
		* command for PCI read operations, instead of using the default PCI Read Line
		* command. Please be aware that this setting may result in read pre-fetching
		* on some platforms.
		*
		* This is free software; you can redistribute it and/or modify
		* it under the terms of the GNU General Public License as published by
		* the Free Software Foundation; either version 2 of the License, or
		@@ -49,9 +54,10 @@ static void dma_init(struct fsl_dma_chan *fsl_chan)
		case FSL_DMA_IP_83XX:
		/* Set the channel to below modes:
		* EOTIE - End-of-transfer interrupt enable
		* PRC_RM - PCI read multiple
		*/
		DMA_OUT(fsl_chan, &fsl_chan->reg_base->mr, FSL_DMA_MR_EOTIE,
		32);
		DMA_OUT(fsl_chan, &fsl_chan->reg_base->mr, FSL_DMA_MR_EOTIE
		\| FSL_DMA_MR_PRC_RM, 32);
		break;
		}

drivers/dma/fsldma.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -38,6 +38,7 @@

		/* Special MR definition for MPC8349 */
		#define FSL_DMA_MR_EOTIE 0x00000080
		#define FSL_DMA_MR_PRC_RM 0x00000800

		#define FSL_DMA_SR_CH 0x00000020
		#define FSL_DMA_SR_PE 0x00000010

Admin message