Commit a7a9456e authored Feb 19, 2020 by Amol Grover Committed by David S. Miller Feb 19, 2020

net: hsr: Pass lockdep expression to RCU lists



node_db is traversed using list_for_each_entry_rcu
outside an RCU read-side critical section but under the protection
of hsr->list_lock.

Hence, add corresponding lockdep expression to silence false-positive
warnings, and harden RCU lists.

Signed-off-by: Amol Grover <frextrite@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 7822dee5

net/hsr/hsr_framereg.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -155,7 +155,8 @@ static struct hsr_node hsr_add_node(struct hsr_priv hsr,
		new_node->seq_out[i] = seq_out;

		spin_lock_bh(&hsr->list_lock);
		list_for_each_entry_rcu(node, node_db, mac_list) {
		list_for_each_entry_rcu(node, node_db, mac_list,
		lockdep_is_held(&hsr->list_lock)) {
		if (ether_addr_equal(node->macaddress_A, addr))
		goto out;
		if (ether_addr_equal(node->macaddress_B, addr))

Admin message