greybus: arche-apb: Don't use gpio after failing to request it (a7a794ec) · Commits · 戴 / test

If devm_gpio_request() returns an error, we shouldn't try to set the direction of the same gpio. Signed-off-by:

drivers/staging/greybus/arche-apb-ctrl.c

+8 −5

Original line number	Diff line number	Diff line
		@@ -137,12 +137,15 @@ static int apb_ctrl_init_seq(struct platform_device *pdev,
		/* On DB3 clock was not mandatory */
		if (gpio_is_valid(apb->clk_en_gpio)) {
		ret = devm_gpio_request(dev, apb->clk_en_gpio, "apb_clk_en");
		if (ret)
		if (ret) {
		dev_warn(dev, "Failed requesting APB clock en gpio %d\n",
		apb->clk_en_gpio);
		} else {
		ret = gpio_direction_output(apb->clk_en_gpio, 1);
		if (ret)
		dev_warn(dev, "failed to set APB clock en gpio dir:%d\n", ret);
		dev_warn(dev, "failed to set APB clock en gpio dir:%d\n",
		ret);
		}
		}
		/* Hold APB in reset state */
		ret = devm_gpio_request(dev, apb->resetn_gpio, "apb-reset");