Commit a7862293 authored May 17, 2018 by Gustavo A. R. Silva Committed by Daniel Borkmann May 17, 2018

bpf: sockmap, fix double-free



`e' is being freed twice.

Fix this by removing one of the kfree() calls.

Addresses-Coverity-ID: 1468983 ("Double free")
Fixes: 81110384 ("bpf: sockmap, add hash map support")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

parent 0e436456

kernel/bpf/sockmap.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1823,7 +1823,6 @@ static int __sock_map_ctx_update_elem(struct bpf_map *map,
		write_unlock_bh(&sock->sk_callback_lock);
		return err;
		out_free:
		kfree(e);
		smap_release_sock(psock, sock);
		out_progs:
		if (verdict)

Admin message