Commit a766fa84 authored Mar 20, 2020 by Dan Carpenter Committed by Jason Gunthorpe Mar 24, 2020

IB/mlx5: Fix a NULL vs IS_ERR() check

The kzalloc() function returns NULL, not error pointers.

Fixes: 30f2fe40 ("IB/mlx5: Introduce UAPIs to manage packet pacing")
Link: https://lore.kernel.org/r/20200320132641.GF95012@mwanda


Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 5fb51863

drivers/infiniband/hw/mlx5/qos.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -46,8 +46,8 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_PP_OBJ_ALLOC)(

		dev = to_mdev(c->ibucontext.device);
		pp_entry = kzalloc(sizeof(*pp_entry), GFP_KERNEL);
		if (IS_ERR(pp_entry))
		return PTR_ERR(pp_entry);
		if (!pp_entry)
		return -ENOMEM;

		in_ctx = uverbs_attr_get_alloced_ptr(attrs,
		MLX5_IB_ATTR_PP_OBJ_ALLOC_CTX);

Admin message