Commit a75fa128 authored Feb 27, 2016 by Colin Ian King Committed by Greg Kroah-Hartman Mar 05, 2016

pch_phub: return -ENODATA if ROM can't be mapped



The error return err is not initialized for the case when pci_map_rom
fails and no ROM can me mapped.  Fix this by setting ret to -ENODATA;
(this is the same error value that is returned if the ROM data is
successfully mapped but does not match the expected ROM signature.).

Issue found from static code analysis using CoverityScan.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 72686447

drivers/misc/pch_phub.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -513,8 +513,10 @@ static ssize_t pch_phub_bin_read(struct file filp, struct kobject kobj,

		/* Get Rom signature */
		chip->pch_phub_extrom_base_address = pci_map_rom(chip->pdev, &rom_size);
		if (!chip->pch_phub_extrom_base_address)
		if (!chip->pch_phub_extrom_base_address) {
		err = -ENODATA;
		goto exrom_map_err;
		}

		pch_phub_read_serial_rom(chip, chip->pch_opt_rom_start_address,
		(unsigned char *)&rom_signature);

Admin message