Commit a75e2d60 authored Oct 28, 2020 by Colin Ian King Committed by Greg Kroah-Hartman Oct 29, 2020

xhci: Fix sizeof() mismatch

An incorrect sizeof() is being used, sizeof(rhub->ports) is not
correct, it should be sizeof(*rhub->ports). This bug did not
cause any issues because it just so happens the sizes are the same.

Fixes: bcaa9d5c ("xhci: Create new structures to store xhci port information")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Link: https://lore.kernel.org/r/20201028203124.375344-2-mathias.nyman@linux.intel.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent befa1c2d

drivers/usb/host/xhci-mem.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2252,8 +2252,8 @@ static void xhci_create_rhub_port_array(struct xhci_hcd *xhci,

		if (!rhub->num_ports)
		return;
		rhub->ports = kcalloc_node(rhub->num_ports, sizeof(rhub->ports), flags,
		dev_to_node(dev));
		rhub->ports = kcalloc_node(rhub->num_ports, sizeof(*rhub->ports),
		flags, dev_to_node(dev));
		for (i = 0; i < HCS_MAX_PORTS(xhci->hcs_params1); i++) {
		if (xhci->hw_ports[i].rhub != rhub \|\|
		xhci->hw_ports[i].hcd_portnum == DUPLICATE_ENTRY)