Commit a75ca930 authored Jun 01, 2020 by yu kuai Committed by Jens Axboe Jun 02, 2020

block/bio-integrity: don't free 'buf' if bio_integrity_add_page() failed



commit e7bf90e5 ("block/bio-integrity: fix a memory leak bug") added
a kfree() for 'buf' if bio_integrity_add_page() returns '0'. However,
the object will be freed in bio_integrity_free() since 'bio->bi_opf' and
'bio->bi_integrity' were set previousy in bio_integrity_alloc().

Fixes: commit e7bf90e5 ("block/bio-integrity: fix a memory leak bug")
Signed-off-by: yu kuai <yukuai3@huawei.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Bob Liu <bob.liu@oracle.com>
Acked-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 1ee08de1

block/bio-integrity.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -281,7 +281,6 @@ bool bio_integrity_prep(struct bio *bio)

		if (ret == 0) {
		printk(KERN_ERR "could not attach integrity payload\n");
		kfree(buf);
		status = BLK_STS_RESOURCE;
		goto err_end_io;
		}

Admin message