Commit a7430847 authored Nov 23, 2007 by David Chinner Committed by Lachlan McIlroy Dec 10, 2007

[XFS] Fix broken inode cluster setup.



The radix tree based inode caches did away with the inode cluster hashes,
replacing them with a bunch of masking and gang lookups on the radix tree.

This masking got broken when moving the code to per-ag radix trees and
indexing by agino # rather than straight inode number. The result is
clustered inode writeback does not cluster and things can go extremely
slowly when there are lots of inodes to write.

Fix it up by comparing the agino # of the inode we just looked up to the
index of the cluster we are looking for.

Tested-by: Torsten Kaiser <just.for.lkml@googlemail.com>

SGI-PV: 972915
SGI-Modid: xfs-linux-melb:xfs-kern:30033a

Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>

parent 77be55a5

fs/xfs/xfs_iget.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -267,7 +267,7 @@ finish_inode:
		icl = NULL;
		if (radix_tree_gang_lookup(&pag->pag_ici_root, (void**)&iq,
		first_index, 1)) {
		if ((iq->i_ino & mask) == first_index)
		if ((XFS_INO_TO_AGINO(mp, iq->i_ino) & mask) == first_index)
		icl = iq->i_cluster;
		}

Admin message