Commit a73fbfce authored Aug 26, 2020 by Randy Dunlap Committed by Masahiro Yamada Sep 03, 2020

kconfig: streamline_config.pl: check defined(ENV variable) before using it



A user reported:
'Use of uninitialized value $ENV{"LMC_KEEP"} in split at
 ./scripts/kconfig/streamline_config.pl line 596.'

so first check that $ENV{LMC_KEEP} is defined before trying
to use it.

Fixes: c027b02d ("streamline_config.pl: add LMC_KEEP to preserve some kconfigs")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

parent 91a9d502

scripts/kconfig/streamline_config.pl

+4 −1

Original line number	Diff line number	Diff line
		@@ -593,7 +593,10 @@ while ($repeat) {
		}

		my %setconfigs;
		my @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
		my @preserved_kconfigs;
		if (defined($ENV{'LMC_KEEP'})) {
		@preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
		}

		sub in_preserved_kconfigs {
		my $kconfig = $config2kfile{$_[0]};

Admin message