Commit a73e24d2 authored Feb 15, 2018 by Jiri Olsa Committed by Arnaldo Carvalho de Melo Feb 16, 2018

perf tools: Do not create kernel maps in sample__resolve()



There's no need for kernel maps to be allocated at this point - sample
processing.

We search for kernel maps using the kernel map_groups in machine::kmaps
which is static. If vmlinux maps for any reason still don't exist, the
search correctly fails because they are not in the map group.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180215122635.24029-9-jolsa@kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent e8f3879f

tools/perf/util/event.c

+0 −11

Original line number	Diff line number	Diff line
		@@ -1588,17 +1588,6 @@ int machine__resolve(struct machine machine, struct addr_location al,
		return -1;

		dump_printf(" ... thread: %s:%d\n", thread__comm_str(thread), thread->tid);
		/*
		* Have we already created the kernel maps for this machine?
		*
		* This should have happened earlier, when we processed the kernel MMAP
		* events, but for older perf.data files there was no such thing, so do
		* it now.
		*/
		if (sample->cpumode == PERF_RECORD_MISC_KERNEL &&
		machine__kernel_map(machine) == NULL)
		machine__create_kernel_maps(machine);

		thread__find_addr_map(thread, sample->cpumode, MAP__FUNCTION, sample->ip, al);
		dump_printf(" ...... dso: %s\n",
		al->map ? al->map->dso->long_name :

Admin message