Commit a73abc28 authored Sep 28, 2020 by Tang Bin Committed by Felipe Balbi Oct 02, 2020

usb: bdc: remove duplicated error message



in case devm_platform_ioremap_resource() fails, that function already
prints a relevant error message which renders the driver's dev_err()
redundant. Let's remove the unnecessary message and, while at that,
also make sure to pass along the error value returned by
devm_platform_ioremap_resource() instead of always returning -ENOMEM.

Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>

[balbi@kernel.org : improved commit log]

Signed-off-by: Felipe Balbi <balbi@kernel.org>

parent ae7e8610

drivers/usb/gadget/udc/bdc/bdc_core.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -510,10 +510,9 @@ static int bdc_probe(struct platform_device *pdev)
		bdc->clk = clk;

		bdc->regs = devm_platform_ioremap_resource(pdev, 0);
		if (IS_ERR(bdc->regs)) {
		dev_err(dev, "ioremap error\n");
		return -ENOMEM;
		}
		if (IS_ERR(bdc->regs))
		return PTR_ERR(bdc->regs);

		irq = platform_get_irq(pdev, 0);
		if (irq < 0)
		return irq;

Admin message