Commit a71a81e7 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Linus Walleij
Browse files

gpio: of: Optimize quirk checks 



Simple string comparisons are cheaper than DT lookups, as the latter
involve taking a spinlock and traversing properties.
Hence optimize quirk checks by postponing DT lookups after string
comparisons.

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarMukesh Ojha <mojha@codeaurora.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 26af3407

drivers/gpio/gpiolib-of.c

+5 −6
Original line number Diff line number Diff line
@@ -86,9 +86,9 @@ static void of_gpio_flags_quirks(struct device_node *np, 
	if (IS_ENABLED(CONFIG_REGULATOR) &&

	    (of_device_is_compatible(np, "regulator-fixed") ||

	     of_device_is_compatible(np, "reg-fixed-voltage") ||

	     (of_device_is_compatible(np, "regulator-gpio") &&

	      !(strcmp(propname, "enable-gpio") &&

	        strcmp(propname, "enable-gpios"))))) {

	     (!(strcmp(propname, "enable-gpio") &&

		strcmp(propname, "enable-gpios")) &&

	      of_device_is_compatible(np, "regulator-gpio")))) {

		/*

		 * The regulator GPIO handles are specified such that the

		 * presence or absence of "enable-active-high" solely controls
@@ -119,9 +119,8 @@ static void of_gpio_flags_quirks(struct device_node *np, 
	 * property named "cs-gpios" we need to inspect the child node

	 * to determine if the flags should have inverted semantics.

	 */

	if (IS_ENABLED(CONFIG_SPI_MASTER) &&

	    of_property_read_bool(np, "cs-gpios") &&

	    !strcmp(propname, "cs-gpios")) {

	if (IS_ENABLED(CONFIG_SPI_MASTER) && !strcmp(propname, "cs-gpios") &&

	    of_property_read_bool(np, "cs-gpios")) {

		struct device_node *child;

		u32 cs;

		int ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE