Commit a6f8de3d authored Nov 08, 2007 by Steve French

[CIFS] Fix stale mode after readdir when cifsacl specified



When mounted with cifsacl mount option, readdir can not
instantiate the inode with the estimated mode based on the ACL
for each file since we have not queried for the ACL for
each of these files yet.  So set the refresh time to zero
for these inodes so that the next stat will cause the client
to go to the server for the ACL info so we can build the estimated
mode (this means we also will issue an extra QueryPathInfo if
the stat happens within 1 second, but this is trivial compared to
the time required to open/getacl/close for each).

ls -l is slower when cifsacl mount option is specified, but
displays correct mode information.

Signed-off-by: Shirish Pargaonkar <shirishp@us.ibm.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent ce06c9f0

fs/cifs/readdir.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -171,6 +171,12 @@ static void fill_in_inode(struct inode *tmp_inode, int new_buf_type,
		/* Linux can not store file creation time unfortunately so ignore it */

		cifsInfo->cifsAttrs = attr;
		#ifdef CONFIG_CIFS_EXPERIMENTAL
		if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_CIFS_ACL) {
		/* get more accurate mode via ACL - so force inode refresh */
		cifsInfo->time = 0;
		} else
		#endif /* CONFIG_CIFS_EXPERIMENTAL */
		cifsInfo->time = jiffies;

		/* treat dos attribute of read-only as read-only mode bit e.g. 555? */

Admin message