Commit a6e2e352 authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Greg Kroah-Hartman
Browse files

bus: mhi: core: Add support for PM state transitions 

This commit adds support for transitioning the MHI states as a
part of the power management operations. Helpers functions are
provided for the state transitions, which will be consumed by the
actual power management routines.

This is based on the patch submitted by Sujeev Dias:
https://lkml.org/lkml/2018/7/9/989



Signed-off-by: default avatarSujeev Dias <sdias@codeaurora.org>
Signed-off-by: default avatarSiddartha Mohanadoss <smohanad@codeaurora.org>
[jhugo: removed dma_zalloc_coherent() and fixed several bugs]
Signed-off-by: default avatarJeffrey Hugo <jhugo@codeaurora.org>
[mani: splitted the pm patch and cleaned up for upstream]
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: default avatarJeffrey Hugo <jhugo@codeaurora.org>
Tested-by: default avatarJeffrey Hugo <jhugo@codeaurora.org>
Link: https://lore.kernel.org/r/20200220095854.4804-7-manivannan.sadhasivam@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6cd330ae

drivers/bus/mhi/core/Makefile

+1 −1
Original line number Diff line number Diff line 
obj-$(CONFIG_MHI_BUS) := mhi.o



mhi-y := init.o main.o
 
mhi-y := init.o main.o pm.o

drivers/bus/mhi/core/init.c

+65 −0
Original line number Diff line number Diff line
@@ -17,6 +17,62 @@ 
#include <linux/wait.h>

#include "internal.h"



const char * const mhi_ee_str[MHI_EE_MAX] = {

	[MHI_EE_PBL] = "PBL",

	[MHI_EE_SBL] = "SBL",

	[MHI_EE_AMSS] = "AMSS",

	[MHI_EE_RDDM] = "RDDM",

	[MHI_EE_WFW] = "WFW",

	[MHI_EE_PTHRU] = "PASS THRU",

	[MHI_EE_EDL] = "EDL",

	[MHI_EE_DISABLE_TRANSITION] = "DISABLE",

	[MHI_EE_NOT_SUPPORTED] = "NOT SUPPORTED",

};



const char * const dev_state_tran_str[DEV_ST_TRANSITION_MAX] = {

	[DEV_ST_TRANSITION_PBL] = "PBL",

	[DEV_ST_TRANSITION_READY] = "READY",

	[DEV_ST_TRANSITION_SBL] = "SBL",

	[DEV_ST_TRANSITION_MISSION_MODE] = "MISSION_MODE",

};



const char * const mhi_state_str[MHI_STATE_MAX] = {

	[MHI_STATE_RESET] = "RESET",

	[MHI_STATE_READY] = "READY",

	[MHI_STATE_M0] = "M0",

	[MHI_STATE_M1] = "M1",

	[MHI_STATE_M2] = "M2",

	[MHI_STATE_M3] = "M3",

	[MHI_STATE_M3_FAST] = "M3_FAST",

	[MHI_STATE_BHI] = "BHI",

	[MHI_STATE_SYS_ERR] = "SYS_ERR",

};



static const char * const mhi_pm_state_str[] = {

	[MHI_PM_STATE_DISABLE] = "DISABLE",

	[MHI_PM_STATE_POR] = "POR",

	[MHI_PM_STATE_M0] = "M0",

	[MHI_PM_STATE_M2] = "M2",

	[MHI_PM_STATE_M3_ENTER] = "M?->M3",

	[MHI_PM_STATE_M3] = "M3",

	[MHI_PM_STATE_M3_EXIT] = "M3->M0",

	[MHI_PM_STATE_FW_DL_ERR] = "FW DL Error",

	[MHI_PM_STATE_SYS_ERR_DETECT] = "SYS_ERR Detect",

	[MHI_PM_STATE_SYS_ERR_PROCESS] = "SYS_ERR Process",

	[MHI_PM_STATE_SHUTDOWN_PROCESS] = "SHUTDOWN Process",

	[MHI_PM_STATE_LD_ERR_FATAL_DETECT] = "LD or Error Fatal Detect",

};



const char *to_mhi_pm_state_str(enum mhi_pm_state state)

{

	int index = find_last_bit((unsigned long *)&state, 32);



	if (index >= ARRAY_SIZE(mhi_pm_state_str))

		return "Invalid State";



	return mhi_pm_state_str[index];

}



int mhi_init_mmio(struct mhi_controller *mhi_cntrl)

{

	u32 val;
@@ -364,6 +420,11 @@ static int parse_config(struct mhi_controller *mhi_cntrl, 
	if (!mhi_cntrl->buffer_len)

		mhi_cntrl->buffer_len = MHI_MAX_MTU;



	/* By default, host is allowed to ring DB in both M0 and M2 states */

	mhi_cntrl->db_access = MHI_PM_M0 | MHI_PM_M2;

	if (config->m2_no_db)

		mhi_cntrl->db_access &= ~MHI_PM_M2;



	return 0;



error_ev_cfg:
@@ -403,8 +464,12 @@ int mhi_register_controller(struct mhi_controller *mhi_cntrl, 
	}



	INIT_LIST_HEAD(&mhi_cntrl->transition_list);

	mutex_init(&mhi_cntrl->pm_mutex);

	rwlock_init(&mhi_cntrl->pm_lock);

	spin_lock_init(&mhi_cntrl->transition_lock);

	spin_lock_init(&mhi_cntrl->wlock);

	INIT_WORK(&mhi_cntrl->st_worker, mhi_pm_st_worker);

	INIT_WORK(&mhi_cntrl->syserr_worker, mhi_pm_sys_err_worker);

	init_waitqueue_head(&mhi_cntrl->state_event);



	mhi_cmd = mhi_cntrl->mhi_cmd;

drivers/bus/mhi/core/internal.h

+175 −0
Original line number Diff line number Diff line
@@ -267,6 +267,79 @@ enum mhi_cmd_type { 
	MHI_CMD_START_CHAN = 18,

};



/* No operation command */

#define MHI_TRE_CMD_NOOP_PTR (0)

#define MHI_TRE_CMD_NOOP_DWORD0 (0)

#define MHI_TRE_CMD_NOOP_DWORD1 (MHI_CMD_NOP << 16)



/* Channel reset command */

#define MHI_TRE_CMD_RESET_PTR (0)

#define MHI_TRE_CMD_RESET_DWORD0 (0)

#define MHI_TRE_CMD_RESET_DWORD1(chid) ((chid << 24) | \

					(MHI_CMD_RESET_CHAN << 16))



/* Channel stop command */

#define MHI_TRE_CMD_STOP_PTR (0)

#define MHI_TRE_CMD_STOP_DWORD0 (0)

#define MHI_TRE_CMD_STOP_DWORD1(chid) ((chid << 24) | \

				       (MHI_CMD_STOP_CHAN << 16))



/* Channel start command */

#define MHI_TRE_CMD_START_PTR (0)

#define MHI_TRE_CMD_START_DWORD0 (0)

#define MHI_TRE_CMD_START_DWORD1(chid) ((chid << 24) | \

					(MHI_CMD_START_CHAN << 16))



#define MHI_TRE_GET_CMD_CHID(tre) (((tre)->dword[1] >> 24) & 0xFF)

#define MHI_TRE_GET_CMD_TYPE(tre) (((tre)->dword[1] >> 16) & 0xFF)



/* Event descriptor macros */

#define MHI_TRE_EV_PTR(ptr) (ptr)

#define MHI_TRE_EV_DWORD0(code, len) ((code << 24) | len)

#define MHI_TRE_EV_DWORD1(chid, type) ((chid << 24) | (type << 16))

#define MHI_TRE_GET_EV_PTR(tre) ((tre)->ptr)

#define MHI_TRE_GET_EV_CODE(tre) (((tre)->dword[0] >> 24) & 0xFF)

#define MHI_TRE_GET_EV_LEN(tre) ((tre)->dword[0] & 0xFFFF)

#define MHI_TRE_GET_EV_CHID(tre) (((tre)->dword[1] >> 24) & 0xFF)

#define MHI_TRE_GET_EV_TYPE(tre) (((tre)->dword[1] >> 16) & 0xFF)

#define MHI_TRE_GET_EV_STATE(tre) (((tre)->dword[0] >> 24) & 0xFF)

#define MHI_TRE_GET_EV_EXECENV(tre) (((tre)->dword[0] >> 24) & 0xFF)

#define MHI_TRE_GET_EV_SEQ(tre) ((tre)->dword[0])

#define MHI_TRE_GET_EV_TIME(tre) ((tre)->ptr)

#define MHI_TRE_GET_EV_COOKIE(tre) lower_32_bits((tre)->ptr)

#define MHI_TRE_GET_EV_VEID(tre) (((tre)->dword[0] >> 16) & 0xFF)

#define MHI_TRE_GET_EV_LINKSPEED(tre) (((tre)->dword[1] >> 24) & 0xFF)

#define MHI_TRE_GET_EV_LINKWIDTH(tre) ((tre)->dword[0] & 0xFF)



/* Transfer descriptor macros */

#define MHI_TRE_DATA_PTR(ptr) (ptr)

#define MHI_TRE_DATA_DWORD0(len) (len & MHI_MAX_MTU)

#define MHI_TRE_DATA_DWORD1(bei, ieot, ieob, chain) ((2 << 16) | (bei << 10) \

	| (ieot << 9) | (ieob << 8) | chain)



/* RSC transfer descriptor macros */

#define MHI_RSCTRE_DATA_PTR(ptr, len) (((u64)len << 48) | ptr)

#define MHI_RSCTRE_DATA_DWORD0(cookie) (cookie)

#define MHI_RSCTRE_DATA_DWORD1 (MHI_PKT_TYPE_COALESCING << 16)



enum mhi_pkt_type {

	MHI_PKT_TYPE_INVALID = 0x0,

	MHI_PKT_TYPE_NOOP_CMD = 0x1,

	MHI_PKT_TYPE_TRANSFER = 0x2,

	MHI_PKT_TYPE_COALESCING = 0x8,

	MHI_PKT_TYPE_RESET_CHAN_CMD = 0x10,

	MHI_PKT_TYPE_STOP_CHAN_CMD = 0x11,

	MHI_PKT_TYPE_START_CHAN_CMD = 0x12,

	MHI_PKT_TYPE_STATE_CHANGE_EVENT = 0x20,

	MHI_PKT_TYPE_CMD_COMPLETION_EVENT = 0x21,

	MHI_PKT_TYPE_TX_EVENT = 0x22,

	MHI_PKT_TYPE_RSC_TX_EVENT = 0x28,

	MHI_PKT_TYPE_EE_EVENT = 0x40,

	MHI_PKT_TYPE_TSYNC_EVENT = 0x48,

	MHI_PKT_TYPE_BW_REQ_EVENT = 0x50,

	MHI_PKT_TYPE_STALE_EVENT, /* internal event */

};



/* MHI transfer completion events */

enum mhi_ev_ccs {

	MHI_EV_CC_INVALID = 0x0,
@@ -292,6 +365,81 @@ enum mhi_ch_state { 
#define MHI_INVALID_BRSTMODE(mode) (mode != MHI_DB_BRST_DISABLE && \

				    mode != MHI_DB_BRST_ENABLE)



extern const char * const mhi_ee_str[MHI_EE_MAX];

#define TO_MHI_EXEC_STR(ee) (((ee) >= MHI_EE_MAX) ? \

			     "INVALID_EE" : mhi_ee_str[ee])



#define MHI_IN_PBL(ee) (ee == MHI_EE_PBL || ee == MHI_EE_PTHRU || \

			ee == MHI_EE_EDL)



#define MHI_IN_MISSION_MODE(ee) (ee == MHI_EE_AMSS || ee == MHI_EE_WFW)



enum dev_st_transition {

	DEV_ST_TRANSITION_PBL,

	DEV_ST_TRANSITION_READY,

	DEV_ST_TRANSITION_SBL,

	DEV_ST_TRANSITION_MISSION_MODE,

	DEV_ST_TRANSITION_MAX,

};



extern const char * const dev_state_tran_str[DEV_ST_TRANSITION_MAX];

#define TO_DEV_STATE_TRANS_STR(state) (((state) >= DEV_ST_TRANSITION_MAX) ? \

				"INVALID_STATE" : dev_state_tran_str[state])



extern const char * const mhi_state_str[MHI_STATE_MAX];

#define TO_MHI_STATE_STR(state) ((state >= MHI_STATE_MAX || \

				  !mhi_state_str[state]) ? \

				"INVALID_STATE" : mhi_state_str[state])



/* internal power states */

enum mhi_pm_state {

	MHI_PM_STATE_DISABLE,

	MHI_PM_STATE_POR,

	MHI_PM_STATE_M0,

	MHI_PM_STATE_M2,

	MHI_PM_STATE_M3_ENTER,

	MHI_PM_STATE_M3,

	MHI_PM_STATE_M3_EXIT,

	MHI_PM_STATE_FW_DL_ERR,

	MHI_PM_STATE_SYS_ERR_DETECT,

	MHI_PM_STATE_SYS_ERR_PROCESS,

	MHI_PM_STATE_SHUTDOWN_PROCESS,

	MHI_PM_STATE_LD_ERR_FATAL_DETECT,

	MHI_PM_STATE_MAX

};



#define MHI_PM_DISABLE			BIT(0)

#define MHI_PM_POR			BIT(1)

#define MHI_PM_M0			BIT(2)

#define MHI_PM_M2			BIT(3)

#define MHI_PM_M3_ENTER			BIT(4)

#define MHI_PM_M3			BIT(5)

#define MHI_PM_M3_EXIT			BIT(6)

/* firmware download failure state */

#define MHI_PM_FW_DL_ERR		BIT(7)

#define MHI_PM_SYS_ERR_DETECT		BIT(8)

#define MHI_PM_SYS_ERR_PROCESS		BIT(9)

#define MHI_PM_SHUTDOWN_PROCESS		BIT(10)

/* link not accessible */

#define MHI_PM_LD_ERR_FATAL_DETECT	BIT(11)



#define MHI_REG_ACCESS_VALID(pm_state) ((pm_state & (MHI_PM_POR | MHI_PM_M0 | \

		MHI_PM_M2 | MHI_PM_M3_ENTER | MHI_PM_M3_EXIT | \

		MHI_PM_SYS_ERR_DETECT | MHI_PM_SYS_ERR_PROCESS | \

		MHI_PM_SHUTDOWN_PROCESS | MHI_PM_FW_DL_ERR)))

#define MHI_PM_IN_ERROR_STATE(pm_state) (pm_state >= MHI_PM_FW_DL_ERR)

#define MHI_PM_IN_FATAL_STATE(pm_state) (pm_state == MHI_PM_LD_ERR_FATAL_DETECT)

#define MHI_DB_ACCESS_VALID(mhi_cntrl) (mhi_cntrl->pm_state & \

					mhi_cntrl->db_access)

#define MHI_WAKE_DB_CLEAR_VALID(pm_state) (pm_state & (MHI_PM_M0 | \

						MHI_PM_M2 | MHI_PM_M3_EXIT))

#define MHI_WAKE_DB_SET_VALID(pm_state) (pm_state & MHI_PM_M2)

#define MHI_WAKE_DB_FORCE_SET_VALID(pm_state) MHI_WAKE_DB_CLEAR_VALID(pm_state)

#define MHI_EVENT_ACCESS_INVALID(pm_state) (pm_state == MHI_PM_DISABLE || \

					    MHI_PM_IN_ERROR_STATE(pm_state))

#define MHI_PM_IN_SUSPEND_STATE(pm_state) (pm_state & \

					   (MHI_PM_M3_ENTER | MHI_PM_M3))



#define NR_OF_CMD_RINGS			1

#define CMD_EL_PER_RING			128

#define PRIMARY_CMD_RING		0
@@ -314,6 +462,16 @@ struct db_cfg { 
			   dma_addr_t db_val);

};



struct mhi_pm_transitions {

	enum mhi_pm_state from_state;

	u32 to_states;

};



struct state_transition {

	struct list_head node;

	enum dev_st_transition state;

};



struct mhi_ring {

	dma_addr_t dma_handle;

	dma_addr_t iommu_base;
@@ -405,6 +563,23 @@ struct mhi_device *mhi_alloc_device(struct mhi_controller *mhi_cntrl); 
int mhi_destroy_device(struct device *dev, void *data);

void mhi_create_devices(struct mhi_controller *mhi_cntrl);



/* Power management APIs */

enum mhi_pm_state __must_check mhi_tryset_pm_state(

					struct mhi_controller *mhi_cntrl,

					enum mhi_pm_state state);

const char *to_mhi_pm_state_str(enum mhi_pm_state state);

enum mhi_ee_type mhi_get_exec_env(struct mhi_controller *mhi_cntrl);

int mhi_queue_state_transition(struct mhi_controller *mhi_cntrl,

			       enum dev_st_transition state);

void mhi_pm_st_worker(struct work_struct *work);

void mhi_pm_sys_err_worker(struct work_struct *work);

int mhi_ready_state_transition(struct mhi_controller *mhi_cntrl);

void mhi_ctrl_ev_task(unsigned long data);

int mhi_pm_m0_transition(struct mhi_controller *mhi_cntrl);

void mhi_pm_m1_transition(struct mhi_controller *mhi_cntrl);

int mhi_pm_m3_transition(struct mhi_controller *mhi_cntrl);

int __mhi_device_get_sync(struct mhi_controller *mhi_cntrl);



/* Register access methods */

void mhi_db_brstmode(struct mhi_controller *mhi_cntrl, struct db_cfg *db_cfg,

		     void __iomem *db_addr, dma_addr_t db_val);

drivers/bus/mhi/core/main.c

+9 −0
Original line number Diff line number Diff line
@@ -133,6 +133,15 @@ enum mhi_ee_type mhi_get_exec_env(struct mhi_controller *mhi_cntrl) 
	return (ret) ? MHI_EE_MAX : exec;

}



enum mhi_state mhi_get_mhi_state(struct mhi_controller *mhi_cntrl)

{

	u32 state;

	int ret = mhi_read_reg_field(mhi_cntrl, mhi_cntrl->regs, MHISTATUS,

				     MHISTATUS_MHISTATE_MASK,

				     MHISTATUS_MHISTATE_SHIFT, &state);

	return ret ? MHI_STATE_MAX : state;

}



int mhi_destroy_device(struct device *dev, void *data)

{

	struct mhi_device *mhi_dev;

drivers/bus/mhi/core/pm.c

0 → 100644
+678 −0

File added.

Preview size limit exceeded, changes collapsed.

CRA Git | Maintained and supported by SUSTech CRA and CCSE