Commit a6d403ac authored Jun 25, 2015 by Tejun Heo Committed by Linus Torvalds Jun 25, 2015

netconsole: remove unnecessary netconsole_target_get/out() from write_msg()



write_msg() grabs target_list_lock and walks target_list invoking
netpool_send_udp() on each target.  Curiously, it protects each iteration
with netconsole_target_get/put() even though it never releases
target_list_lock which protects all the members.

While this doesn't harm anything, it doesn't serve any purpose either.
The items on the list can't go away while target_list_lock is held.
Remove the unnecessary get/put pair.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: David Miller <davem@davemloft.net>
Cc: Kay Sievers <kay@vrfy.org>
Cc: Petr Mladek <pmladek@suse.cz>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 6fe29354

drivers/net/netconsole.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -744,7 +744,6 @@ static void write_msg(struct console con, const char msg, unsigned int len)

		spin_lock_irqsave(&target_list_lock, flags);
		list_for_each_entry(nt, &target_list, list) {
		netconsole_target_get(nt);
		if (nt->enabled && netif_running(nt->np.dev)) {
		/*
		* We nest this inside the for-each-target loop above
		@@ -760,7 +759,6 @@ static void write_msg(struct console con, const char msg, unsigned int len)
		left -= frag;
		}
		}
		netconsole_target_put(nt);
		}
		spin_unlock_irqrestore(&target_list_lock, flags);
		}

Admin message