Commit a6cd27e9 authored Apr 22, 2020 by Alan Stern Committed by Greg Kroah-Hartman Apr 23, 2020

USB: core: Replace an empty statement with a debug message



This patch adds a dev_dbg() message to usb_create_sysfs_intf_files().
The message is not expected ever to appear; it's real purpose is to
satisfy the __must_check attribute on device_create_file() without
triggering a compiler warning about an empty statement.

In fact we don't really care if the sysfs attribute file doesn't get
created.  The interface string descriptor is purely informational and
hardly ever present.

Suggested-by: NeilBrown <neilb@suse.de>
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>

Link: https://lore.kernel.org/r/Pine.LNX.4.44L0.2004221618500.11262-100000@iolanthe.rowland.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 27b0387b

drivers/usb/core/sysfs.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -1262,8 +1262,10 @@ void usb_create_sysfs_intf_files(struct usb_interface *intf)

		if (!alt->string && !(udev->quirks & USB_QUIRK_CONFIG_INTF_STRINGS))
		alt->string = usb_cache_string(udev, alt->desc.iInterface);
		if (alt->string && device_create_file(&intf->dev, &dev_attr_interface))
		; /* We don't actually care if the function fails. */
		if (alt->string && device_create_file(&intf->dev, &dev_attr_interface)) {
		/* This is not a serious error */
		dev_dbg(&intf->dev, "interface string descriptor file not created\n");
		}
		intf->sysfs_files_created = 1;
		}

Admin message