Commit a6b65983 authored May 19, 2015 by Wei Yang Committed by Bjorn Helgaas May 27, 2015

PCI: Fix IOV resource sorting by alignment requirement



In d74b9027 ("PCI: Consider additional PF's IOV BAR alignment in sizing
and assigning"), it stores additional alignment in realloc_head and takes
this into consideration for assignment.

After getting the additional alignment, it reorders the head list so
resources with bigger alignment are ahead of resources with smaller
alignment.  It does this by iterating over the head list and inserting
ahead of any resource with smaller alignment.  This should be done for the
first occurrence, but the code currently iterates over the whole list.

Fix this by terminating the loop when we find the first smaller resource in
the head list.

[bhelgaas: changelog]
Fixes: d74b9027 ("PCI: Consider additional PF's IOV BAR alignment in sizing and assigning")
Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent 110baab1

drivers/pci/setup-bus.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -435,9 +435,11 @@ static void __assign_resources_sorted(struct list_head *head,
		list_for_each_entry(dev_res2, head, list) {
		align = pci_resource_alignment(dev_res2->dev,
		dev_res2->res);
		if (add_align > align)
		if (add_align > align) {
		list_move_tail(&dev_res->list,
		&dev_res2->list);
		break;
		}
		}
		}

Admin message