Commit a69d3bdd authored Oct 04, 2019 by Colin Ian King Committed by Kalle Valo Oct 11, 2019

ath10k: fix null dereference on pointer crash_data



Currently when pointer crash_data is null the present null check
will also check that crash_data->ramdump_buf is null and will cause
a null pointer dereference on crash_data. Fix this by using the ||
operator instead of &&.

Fixes: 3f14b73c ("ath10k: Enable MSA region dump support for WCN3990")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent cc78dc3b

drivers/net/wireless/ath/ath10k/snoc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1400,7 +1400,7 @@ static void ath10k_msa_dump_memory(struct ath10k *ar,
		size_t buf_len;
		u8 *buf;

		if (!crash_data && !crash_data->ramdump_buf)
		if (!crash_data \|\| !crash_data->ramdump_buf)
		return;

		mem_layout = ath10k_coredump_get_mem_layout(ar);

Admin message