Commit a6994eb0 authored by Jarod Wilson's avatar Jarod Wilson Committed by Mauro Carvalho Chehab
Browse files

[media] mceusb: don't claim multifunction device non-IR parts 



There's a Realtek combo card reader and IR receiver device with multiple
usb interfaces on it. The mceusb driver is incorrectly grabbing all of
them. This change should make it bind to only interface 2 (patch based
on lsusb output on the linux-media list from Lucian Muresan).

Tested regression-free with the six mceusb devices I have myself.

Reported-by: default avatarPatrick Boettcher <pboettcher@kernellabs.com>
Reported-by: default avatarLucian Muresan <lucianm@users.sourceforge.net>
Signed-off-by: default avatarJarod Wilson <jarod@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 3198ed16

drivers/media/rc/mceusb.c

+15 −12
Original line number Diff line number Diff line
@@ -148,6 +148,7 @@ enum mceusb_model_type { 
	MCE_GEN2_TX_INV,

	POLARIS_EVK,

	CX_HYBRID_TV,

	MULTIFUNCTION,

};



struct mceusb_model {
@@ -155,9 +156,10 @@ struct mceusb_model { 
	u32 mce_gen2:1;

	u32 mce_gen3:1;

	u32 tx_mask_normal:1;

	u32 is_polaris:1;

	u32 no_tx:1;



	int ir_intfnum;



	const char *rc_map;	/* Allow specify a per-board map */

	const char *name;	/* per-board name */

};
@@ -179,7 +181,6 @@ static const struct mceusb_model mceusb_model[] = { 
		.tx_mask_normal = 1,

	},

	[POLARIS_EVK] = {

		.is_polaris = 1,

		/*

		 * In fact, the EVK is shipped without

		 * remotes, but we should have something handy,
@@ -189,10 +190,13 @@ static const struct mceusb_model mceusb_model[] = { 
		.name = "Conexant Hybrid TV (cx231xx) MCE IR",

	},

	[CX_HYBRID_TV] = {

		.is_polaris = 1,

		.no_tx = 1, /* tx isn't wired up at all */

		.name = "Conexant Hybrid TV (cx231xx) MCE IR",

	},

	[MULTIFUNCTION] = {

		.mce_gen2 = 1,

		.ir_intfnum = 2,

	},

};



static struct usb_device_id mceusb_dev_table[] = {
@@ -216,8 +220,9 @@ static struct usb_device_id mceusb_dev_table[] = { 
	{ USB_DEVICE(VENDOR_PHILIPS, 0x206c) },

	/* Philips/Spinel plus IR transceiver for ASUS */

	{ USB_DEVICE(VENDOR_PHILIPS, 0x2088) },

	/* Realtek MCE IR Receiver */

	{ USB_DEVICE(VENDOR_REALTEK, 0x0161) },

	/* Realtek MCE IR Receiver and card reader */

	{ USB_DEVICE(VENDOR_REALTEK, 0x0161),

	  .driver_info = MULTIFUNCTION },

	/* SMK/Toshiba G83C0004D410 */

	{ USB_DEVICE(VENDOR_SMK, 0x031d),

	  .driver_info = MCE_GEN2_TX_INV },
@@ -1101,7 +1106,7 @@ static int __devinit mceusb_dev_probe(struct usb_interface *intf, 
	bool is_gen3;

	bool is_microsoft_gen1;

	bool tx_mask_normal;

	bool is_polaris;

	int ir_intfnum;



	dev_dbg(&intf->dev, "%s called\n", __func__);
@@ -1110,13 +1115,11 @@ static int __devinit mceusb_dev_probe(struct usb_interface *intf, 
	is_gen3 = mceusb_model[model].mce_gen3;

	is_microsoft_gen1 = mceusb_model[model].mce_gen1;

	tx_mask_normal = mceusb_model[model].tx_mask_normal;

	is_polaris = mceusb_model[model].is_polaris;

	ir_intfnum = mceusb_model[model].ir_intfnum;



	if (is_polaris) {

		/* Interface 0 is IR */

		if (idesc->desc.bInterfaceNumber)

	/* There are multi-function devices with non-IR interfaces */

	if (idesc->desc.bInterfaceNumber != ir_intfnum)

		return -ENODEV;

	}



	/* step through the endpoints to find first bulk in and out endpoint */

	for (i = 0; i < idesc->desc.bNumEndpoints; ++i) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE