Commit a687c576 authored Feb 24, 2017 by Roderick Colenbrander Committed by Jiri Kosina Mar 06, 2017

HID: sony: Fix input device leak when connecting a DS4 twice using USB/BT



When a user connects a DS4 twice using USB and BT, we reject the
second device connection after the setup work. We then perform
a cleanup, but during cleanup we are not removing the touchpad
device. This leads to leakage of an input device, which we would
never remove. It can likely result into a kernel oops as well
when the touchpad evdev node is accessed and the underlaying HID
device has been removed from the system.

[jkosina@suse.cz: added stable annotation]
Fixes: ac797b95 ("HID: sony: Make the DS4 touchpad a separate device")
Cc: stable@vger.kernel.org
Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent f2f10b7e

drivers/hid/hid-sony.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -2632,6 +2632,8 @@ err_stop:
		sony_leds_remove(sc);
		if (sc->quirks & SONY_BATTERY_SUPPORT)
		sony_battery_remove(sc);
		if (sc->touchpad)
		sony_unregister_touchpad(sc);
		sony_cancel_work_sync(sc);
		kfree(sc->output_report_dmabuf);
		sony_remove_dev_list(sc);

Admin message