Commit a684d69d authored Apr 02, 2008 by Mark McLoughlin Committed by Ingo Molnar Apr 04, 2008

xen: Do not pin/unpin PMD pages

i.e. with this simple test case:

    int fd = open("/dev/zero", O_RDONLY);
    munmap(mmap((void *)0x40000000, 0x1000_LEN, PROT_READ, MAP_PRIVATE, fd, 0), 0x1000);
    close(fd);

we currently get:

   kernel BUG at arch/x86/xen/enlighten.c:678!
   ...
   EIP is at xen_release_pt+0x79/0xa9
   ...
   Call Trace:
    [<c041da25>] ? __pmd_free_tlb+0x1a/0x75
    [<c047a192>] ? free_pgd_range+0x1d2/0x2b5
    [<c047a2f3>] ? free_pgtables+0x7e/0x93
    [<c047b272>] ? unmap_region+0xb9/0xf5
    [<c047c1bd>] ? do_munmap+0x193/0x1f5
    [<c047c24f>] ? sys_munmap+0x30/0x3f
    [<c0408cce>] ? syscall_call+0x7/0xb
    =======================

and xen complains:

  (XEN) mm.c:2241:d4 Mfn 1cc37 not pinned

Further details at:

  https://bugzilla.redhat.com/436453



Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Cc: xen-devel@lists.xensource.com
Cc: Mark McLoughlin <markmc@redhat.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent f6433706

arch/x86/xen/enlighten.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -689,8 +689,6 @@ static void xen_alloc_ptpage(struct mm_struct *mm, u32 pfn, unsigned level)
		make_lowmem_page_readonly(__va(PFN_PHYS(pfn)));
		if (level == PT_PTE)
		pin_pagetable_pfn(MMUEXT_PIN_L1_TABLE, pfn);
		else if (level == PT_PMD)
		pin_pagetable_pfn(MMUEXT_PIN_L2_TABLE, pfn);
		} else
		/* make sure there are no stray mappings of
		this page */
		@@ -715,6 +713,7 @@ static void xen_release_ptpage(u32 pfn, unsigned level)

		if (PagePinned(page)) {
		if (!PageHighMem(page)) {
		if (level == PT_PTE)
		pin_pagetable_pfn(MMUEXT_UNPIN_TABLE, pfn);
		make_lowmem_page_readwrite(__va(PFN_PHYS(pfn)));
		}

Admin message