net/mlx5e: replace EINVAL in mlx5e_flower_parse_meta() (a683012a) · Commits · 戴 / test

The drivers reports EINVAL to userspace through netlink on invalid meta match. This is confusing since EINVAL is usually reserved for malformed netlink messages. Replace it by more meaningful codes. Fixes: ("net/mlx5e: Add mlx5e_flower_parse_meta support") Signed-off-by:

Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by:

Saeed Mahameed <saeedm@mellanox.com>

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -2068,7 +2068,7 @@ static int mlx5e_flower_parse_meta(struct net_device *filter_dev,
		flow_rule_match_meta(rule, &match);
		if (match.mask->ingress_ifindex != 0xFFFFFFFF) {
		NL_SET_ERR_MSG_MOD(extack, "Unsupported ingress ifindex mask");
		return -EINVAL;
		return -EOPNOTSUPP;
		}

		ingress_dev = __dev_get_by_index(dev_net(filter_dev),
		@@ -2076,13 +2076,13 @@ static int mlx5e_flower_parse_meta(struct net_device *filter_dev,
		if (!ingress_dev) {
		NL_SET_ERR_MSG_MOD(extack,
		"Can't find the ingress port to match on");
		return -EINVAL;
		return -ENOENT;
		}

		if (ingress_dev != filter_dev) {
		NL_SET_ERR_MSG_MOD(extack,
		"Can't match on the ingress filter port");
		return -EINVAL;
		return -EOPNOTSUPP;
		}

		return 0;

Admin message