Commit a6706020 authored Aug 06, 2019 by Wenwen Wang Committed by Takashi Iwai Aug 06, 2019

ALSA: usb-audio: fix a memory leak bug



In snd_usb_get_audioformat_uac3(), a structure for channel maps 'chmap' is
allocated through kzalloc() before the execution goto 'found_clock'.
However, this structure is not deallocated if the memory allocation for
'pd' fails, leading to a memory leak bug.

To fix the above issue, free 'fp->chmap' before returning NULL.

Fixes: 7edf3b5e ("ALSA: usb-audio: AudioStreaming Power Domain parsing")
Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent d1d03306

sound/usb/stream.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1043,6 +1043,7 @@ found_clock:

		pd = kzalloc(sizeof(*pd), GFP_KERNEL);
		if (!pd) {
		kfree(fp->chmap);
		kfree(fp->rate_table);
		kfree(fp);
		return NULL;

Admin message