spi: bitbang: Don't call chipselect() in spi_bitbang_setup() (a666f261) · Commits · 戴 / test

spi_setup() already call spi_set_cs() right after calling the controller setup method, so there is no need for the bitbang driver to do that. Because of this the chipselect() callback was confusingly still called when CS is GPIO based. Signed-off-by:

Alban Bedel <albeu@free.fr> Signed-off-by:

Mark Brown <broonie@kernel.org>

drivers/spi/spi-bitbang.c

+0 −13

Original line number	Diff line number	Diff line
		@@ -213,19 +213,6 @@ int spi_bitbang_setup(struct spi_device *spi)

		dev_dbg(&spi->dev, "%s, %u nsec/bit\n", __func__, 2 * cs->nsecs);

		/* NOTE we _need_ to call chipselect() early, ideally with adapter
		* setup, unless the hardware defaults cooperate to avoid confusion
		* between normal (active low) and inverted chipselects.
		*/

		/* deselect chip (low or high) */
		mutex_lock(&bitbang->lock);
		if (!bitbang->busy) {
		bitbang->chipselect(spi, BITBANG_CS_INACTIVE);
		ndelay(cs->nsecs);
		}
		mutex_unlock(&bitbang->lock);

		return 0;
		}
		EXPORT_SYMBOL_GPL(spi_bitbang_setup);

Admin message