Commit a663e0df authored Oct 07, 2020 by Mika Westerberg

thunderbolt: Fix memory leak if ida_simple_get() fails in enumerate_services()



The svc->key field is not released as it should be if ida_simple_get()
fails so fix that.

Fixes: 9aabb685 ("thunderbolt: Fix to check return value of ida_simple_get")
Cc: stable@vger.kernel.org
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>

parent 7342ca34

drivers/thunderbolt/xdomain.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -881,6 +881,7 @@ static void enumerate_services(struct tb_xdomain *xd)

		id = ida_simple_get(&xd->service_ids, 0, 0, GFP_KERNEL);
		if (id < 0) {
		kfree(svc->key);
		kfree(svc);
		break;
		}

Admin message