Commit a65aa9c3 authored Apr 27, 2020 by Vasily Averin Committed by Gerd Hoffmann Apr 28, 2020

drm/qxl: qxl_release leak in qxl_hw_surface_alloc()



Cc: stable@vger.kernel.org
Fixes: 8002db63 ("qxl: convert qxl driver to proper use for reservations")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Link: http://patchwork.freedesktop.org/patch/msgid/2e5a13ae-9ab2-5401-aa4d-03d5f5593423@virtuozzo.com


Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

parent 85e9b88a

drivers/gpu/drm/qxl/qxl_cmd.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -480,9 +480,10 @@ int qxl_hw_surface_alloc(struct qxl_device *qdev,
		return ret;

		ret = qxl_release_reserve_list(release, true);
		if (ret)
		if (ret) {
		qxl_release_free(qdev, release);
		return ret;

		}
		cmd = (struct qxl_surface_cmd *)qxl_release_map(qdev, release);
		cmd->type = QXL_SURFACE_CMD_CREATE;
		cmd->flags = QXL_SURF_FLAG_KEEP_DATA;

Admin message