Commit a6592547 authored Jul 03, 2018 by Xin Long Committed by David S. Miller Jul 04, 2018

sctp: fix the issue that pathmtu may be set lower than MINSEGMENT



After commit b6c5734d ("sctp: fix the handling of ICMP Frag Needed
for too small MTUs"), sctp_transport_update_pmtu would refetch pathmtu
from the dst and set it to transport's pathmtu without any check.

The new pathmtu may be lower than MINSEGMENT if the dst is obsolete and
updated by .get_dst() in sctp_transport_update_pmtu. In this case, it
could have a smaller MTU as well, and thus we should validate it
against MINSEGMENT instead.

Syzbot reported a warning in sctp_mtu_payload caused by this.

This patch refetches the pathmtu by calling sctp_dst_mtu where it does
the check against MINSEGMENT.

v1->v2:
  - refetch the pathmtu by calling sctp_dst_mtu instead as Marcelo's
    suggestion.

Fixes: b6c5734d ("sctp: fix the handling of ICMP Frag Needed for too small MTUs")
Reported-by:  <syzbot+f0d9d7cba052f9344b03@syzkaller.appspotmail.com>
Suggested-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 33bd5ac5

net/sctp/transport.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -282,7 +282,7 @@ bool sctp_transport_update_pmtu(struct sctp_transport *t, u32 pmtu)

		if (dst) {
		/* Re-fetch, as under layers may have a higher minimum size */
		pmtu = SCTP_TRUNC4(dst_mtu(dst));
		pmtu = sctp_dst_mtu(dst);
		change = t->pathmtu != pmtu;
		}
		t->pathmtu = pmtu;

Admin message