Commit a6532e71 authored Jan 12, 2018 by Parav Pandit Committed by Jason Gunthorpe Jan 15, 2018

RDMA/core: Clarify rdma_ah_find_type



iWARP does not use rdma_ah_attr_type, and for this reason we do not have a
RDMA_AH_ATTR_TYPE_IWARP. rdma_ah_find_type should not even be called on iwarp
ports and for clarity it shouldn't have a special test for iWarp.

This changes the result from RDMA_AH_ATTR_TYPE_ROCE to RDMA_AH_ATTR_TYPE_IB
when wrongly called on an iWarp port.

Fixes: 44c58487 ("IB/core: Define 'ib' and 'roce' rdma_ah_attr types")
Signed-off-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent cd2a6e7d

include/rdma/ib_verbs.h

+1 −2

Original line number	Diff line number	Diff line
		@@ -3793,8 +3793,7 @@ static inline void rdma_ah_set_grh(struct rdma_ah_attr *attr,
		static inline enum rdma_ah_attr_type rdma_ah_find_type(struct ib_device *dev,
		u32 port_num)
		{
		if ((rdma_protocol_roce(dev, port_num)) \|\|
		(rdma_protocol_iwarp(dev, port_num)))
		if (rdma_protocol_roce(dev, port_num))
		return RDMA_AH_ATTR_TYPE_ROCE;
		else if ((rdma_protocol_ib(dev, port_num)) &&
		(rdma_cap_opa_ah(dev, port_num)))

Admin message