Commit a6435f3a authored Feb 25, 2009 by Matt Carlson Committed by David S. Miller Feb 26, 2009

tg3: Fix 5906 link problems



Commit 6833c043 introduced the phy
auto-powerdown capability.  While the APD feature only works for 5761
and 5784 asic revisions, the (harmless portion of the) code was applied
to all 5705 and newer devices.  However, the 5906 phy departs from the
usual design.  This commit was interfering with the 5906's ability to
negotiate link against some switches.  This patch corrects the problem.

Signed-off-by: Matt Carlson <mcarlson@broadcom.com>
Signed-off-by: Benjamin Li <benli@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9ee62630

drivers/net/tg3.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1473,7 +1473,8 @@ static void tg3_phy_toggle_apd(struct tg3 *tp, bool enable)
		{
		u32 reg;

		if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS))
		if (!(tp->tg3_flags2 & TG3_FLG2_5705_PLUS) \|\|
		GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5906)
		return;

		reg = MII_TG3_MISC_SHDW_WREN \|

Admin message