Commit a6116c9e authored Apr 23, 2008 by Mark Lord Committed by Jeff Garzik Apr 25, 2008

libata-eh set tf flags in NCQ EH result_tf



Fix mis-reporting of NCQ errors by ensuring that result_tf->flags
is properly initialized in libata-eh.  This allows ata_gen_ata_sense()
to report the failed block number correctly to SCSI after a media error
during NCQ.

This patch may also be a candidate for backporting to earlier kernels.
Without this fix, SCSI will fail I/O on the entire request rather
than just the bad sector.  That can be bad for a request that was
merged from many independent read reads from different tasks.

Signed-off-by: Mark Lord <mlord@pobox.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>

parent 1dc55e87

drivers/ata/libata-eh.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1402,6 +1402,7 @@ static void ata_eh_analyze_ncq_error(struct ata_link *link)
		/* we've got the perpetrator, condemn it */
		qc = __ata_qc_from_tag(ap, tag);
		memcpy(&qc->result_tf, &tf, sizeof(tf));
		qc->result_tf.flags = ATA_TFLAG_ISADDR \| ATA_TFLAG_LBA \| ATA_TFLAG_LBA48;
		qc->err_mask \|= AC_ERR_DEV \| AC_ERR_NCQ;
		ehc->i.err_mask &= ~AC_ERR_DEV;
		}

Admin message