Commit a5f6fc28 authored Nov 19, 2014 by Mathias Krause Committed by David S. Miller Nov 20, 2014

pptp: fix stack info leak in pptp_getname()



pptp_getname() only partially initializes the stack variable sa,
particularly only fills the pptp part of the sa_addr union. The code
thereby discloses 16 bytes of kernel stack memory via getsockname().

Fix this by memset(0)'ing the union before.

Cc: Dmitry Kozlov <xeb@mail.ru>
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ee7255ad

drivers/net/ppp/pptp.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -506,6 +506,8 @@ static int pptp_getname(struct socket sock, struct sockaddr uaddr,
		int len = sizeof(struct sockaddr_pppox);
		struct sockaddr_pppox sp;

		memset(&sp.sa_addr, 0, sizeof(sp.sa_addr));

		sp.sa_family = AF_PPPOX;
		sp.sa_protocol = PX_PROTO_PPTP;
		sp.sa_addr.pptp = pppox_sk(sock->sk)->proto.pptp.src_addr;

Admin message