err.h: use bool for IS_ERR and IS_ERR_OR_NULL (a5ed3cee) · Commits · 戴 / test

Use the more natural return of bool for these tests. No difference observed in .o files produced by gcc for x86. Remove the dentry description of kernel pointers left over from the 90's and 2002's cleanup move of parts of fs.h to err.h. Signed-off-by:

Joe Perches <joe@perches.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

include/linux/err.h

+4 −3

Original line number	Diff line number	Diff line
		@@ -2,12 +2,13 @@
		#define _LINUX_ERR_H

		#include <linux/compiler.h>
		#include <linux/types.h>

		#include <asm/errno.h>

		/*
		* Kernel pointers have redundant information, so we can use a
		* scheme where we can return either an error code or a dentry
		* scheme where we can return either an error code or a normal
		* pointer with the same return value.
		*
		* This should be a per-architecture thing, to allow different
		@@ -29,12 +30,12 @@ static inline long __must_check PTR_ERR(__force const void *ptr)
		return (long) ptr;
		}

		static inline long __must_check IS_ERR(__force const void *ptr)
		static inline bool __must_check IS_ERR(__force const void *ptr)
		{
		return IS_ERR_VALUE((unsigned long)ptr);
		}

		static inline long __must_check IS_ERR_OR_NULL(__force const void *ptr)
		static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr)
		{
		return !ptr \|\| IS_ERR_VALUE((unsigned long)ptr);
		}

Admin message