fm10k: reduce scope of *p local variable (a5c0d861) · Commits · 戴 / test

Reduce the scope of the char *p local variable to only the block where it is used. This was detected by cppcheck and resolves the following style warning produced by that tool: [fm10k_ethtool.c:229]: (style) The scope of the variable 'p' can be reduced. Signed-off-by:

Jacob Keller <jacob.e.keller@intel.com> Tested-by:

Andrew Bowers <andrewx.bowers@intel.com> Signed-off-by:

Jeff Kirsher <jeffrey.t.kirsher@intel.com>

drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c

+2 −3

Original line number	Diff line number	Diff line
		// SPDX-License-Identifier: GPL-2.0
		/* Copyright(c) 2013 - 2018 Intel Corporation. */
		/* Copyright(c) 2013 - 2019 Intel Corporation. */

		#include <linux/vmalloc.h>

		@@ -222,7 +222,6 @@ static void __fm10k_add_ethtool_stats(u64 *data, void pointer,
		const unsigned int size)
		{
		unsigned int i;
		char *p;

		if (!pointer) {
		/* memory is not zero allocated so we have to clear it */
		@@ -232,7 +231,7 @@ static void __fm10k_add_ethtool_stats(u64 *data, void pointer,
		}

		for (i = 0; i < size; i++) {
		p = (char *)pointer + stats[i].stat_offset;
		char p = (char )pointer + stats[i].stat_offset;

		switch (stats[i].sizeof_stat) {
		case sizeof(u64):

Admin message