Commit a5b1d541 authored by Sakari Ailus's avatar Sakari Ailus Committed by Mauro Carvalho Chehab
Browse files

media: smiapp: Fix error handling at NVM reading 



If NVM reading failed, the device was left powered on. Fix that.

Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 837c07eb

drivers/media/i2c/smiapp/smiapp-core.c

+2 −1
Original line number Diff line number Diff line
@@ -2326,11 +2326,12 @@ smiapp_sysfs_nvm_read(struct device *dev, struct device_attribute *attr, 
		if (rval < 0) {

			if (rval != -EBUSY && rval != -EAGAIN)

				pm_runtime_set_active(&client->dev);

			pm_runtime_put(&client->dev);

			pm_runtime_put_noidle(&client->dev);

			return -ENODEV;

		}



		if (smiapp_read_nvm(sensor, sensor->nvm)) {

			pm_runtime_put(&client->dev);

			dev_err(&client->dev, "nvm read failed\n");

			return -ENODEV;

		}

CRA Git | Maintained and supported by SUSTech CRA and CCSE