Commit a5b19b63 authored Jun 08, 2009 by Yevgeny Petrilin Committed by David S. Miller Jun 08, 2009

mlx4: FIX error flow when initializing EQ table



If mlx4_create_eq() would fail for one of EQ's assigned for
completion handling, the code would try to free the same EQ
we failed to create.
The crash was found by Christoph Lameter

Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6f536f40

drivers/net/mlx4/eq.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -623,9 +623,11 @@ int mlx4_init_eq_table(struct mlx4_dev *dev)
		err = mlx4_create_eq(dev, dev->caps.num_cqs + MLX4_NUM_SPARE_EQE,
		(dev->flags & MLX4_FLAG_MSI_X) ? i : 0,
		&priv->eq_table.eq[i]);
		if (err)
		if (err) {
		--i;
		goto err_out_unmap;
		}
		}

		err = mlx4_create_eq(dev, MLX4_NUM_ASYNC_EQE + MLX4_NUM_SPARE_EQE,
		(dev->flags & MLX4_FLAG_MSI_X) ? dev->caps.num_comp_vectors : 0,

Admin message