Commit a598af7f authored by Dan Carpenter's avatar Dan Carpenter Committed by Chanwoo Choi
Browse files

extcon: Fix signedness bugs about break error handling 



Unsigned is never less than zero so this error handling won't work.

Fixes: be052cc8 ('extcon: Fix hang and extcon_get/set_cable_state().')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarRoger Quadros <rogerq@ti.com>
[cw00.choi: Change the patch title and fix signedness bug of find_cable_index_by_id() ]
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent bef025a1

drivers/extcon/extcon.c

+4 −4
Original line number Diff line number Diff line
@@ -126,7 +126,7 @@ static int find_cable_index_by_id(struct extcon_dev *edev, const unsigned int id 


static int find_cable_id_by_name(struct extcon_dev *edev, const char *name)

{

	unsigned int id = -EINVAL;

	int id = -EINVAL;

	int i = 0;



	/* Find the id of extcon cable */
@@ -143,7 +143,7 @@ static int find_cable_id_by_name(struct extcon_dev *edev, const char *name) 


static int find_cable_index_by_name(struct extcon_dev *edev, const char *name)

{

	unsigned int id;

	int id;



	if (edev->max_supported == 0)

		return -EINVAL;
@@ -379,7 +379,7 @@ EXPORT_SYMBOL_GPL(extcon_get_cable_state_); 
 */

int extcon_get_cable_state(struct extcon_dev *edev, const char *cable_name)

{

	unsigned int id;

	int id;



	id = find_cable_id_by_name(edev, cable_name);

	if (id < 0)
@@ -430,7 +430,7 @@ EXPORT_SYMBOL_GPL(extcon_set_cable_state_); 
int extcon_set_cable_state(struct extcon_dev *edev,

			const char *cable_name, bool cable_state)

{

	unsigned int id;

	int id;



	id = find_cable_id_by_name(edev, cable_name);

	if (id < 0)

CRA Git | Maintained and supported by SUSTech CRA and CCSE