Commit a583636a authored by Craig Gallek's avatar Craig Gallek Committed by David S. Miller
Browse files

inet: refactor inet[6]_lookup functions to take skb 



This is a preliminary step to allow fast socket lookup of SO_REUSEPORT
groups.  Doing so with a BPF filter will require access to the
skb in question.  This change plumbs the skb (and offset to payload
data) through the call stack to the listening socket lookup
implementations where it will be used in a following patch.

Signed-off-by: default avatarCraig Gallek <kraig@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d9b3fca2

include/net/addrconf.h

+2 −0
Original line number Diff line number Diff line
@@ -87,6 +87,8 @@ int __ipv6_get_lladdr(struct inet6_dev *idev, struct in6_addr *addr, 
		      u32 banned_flags);

int ipv6_get_lladdr(struct net_device *dev, struct in6_addr *addr,

		    u32 banned_flags);

int ipv4_rcv_saddr_equal(const struct sock *sk, const struct sock *sk2,

			 bool match_wildcard);

int ipv6_rcv_saddr_equal(const struct sock *sk, const struct sock *sk2,

			 bool match_wildcard);

void addrconf_join_solict(struct net_device *dev, const struct in6_addr *addr);

include/net/inet6_hashtables.h

+7 −4
Original line number Diff line number Diff line
@@ -53,6 +53,7 @@ struct sock *__inet6_lookup_established(struct net *net, 


struct sock *inet6_lookup_listener(struct net *net,

				   struct inet_hashinfo *hashinfo,

				   struct sk_buff *skb, int doff,

				   const struct in6_addr *saddr,

				   const __be16 sport,

				   const struct in6_addr *daddr,
@@ -60,6 +61,7 @@ struct sock *inet6_lookup_listener(struct net *net, 


static inline struct sock *__inet6_lookup(struct net *net,

					  struct inet_hashinfo *hashinfo,

					  struct sk_buff *skb, int doff,

					  const struct in6_addr *saddr,

					  const __be16 sport,

					  const struct in6_addr *daddr,
@@ -71,12 +73,12 @@ static inline struct sock *__inet6_lookup(struct net *net, 
	if (sk)

		return sk;



	return inet6_lookup_listener(net, hashinfo, saddr, sport,

	return inet6_lookup_listener(net, hashinfo, skb, doff, saddr, sport,

				     daddr, hnum, dif);

}



static inline struct sock *__inet6_lookup_skb(struct inet_hashinfo *hashinfo,

					      struct sk_buff *skb,

					      struct sk_buff *skb, int doff,

					      const __be16 sport,

					      const __be16 dport,

					      int iif)
@@ -86,13 +88,14 @@ static inline struct sock *__inet6_lookup_skb(struct inet_hashinfo *hashinfo, 
	if (sk)

		return sk;



	return __inet6_lookup(dev_net(skb_dst(skb)->dev), hashinfo,

			      &ipv6_hdr(skb)->saddr, sport,

	return __inet6_lookup(dev_net(skb_dst(skb)->dev), hashinfo, skb,

			      doff, &ipv6_hdr(skb)->saddr, sport,

			      &ipv6_hdr(skb)->daddr, ntohs(dport),

			      iif);

}



struct sock *inet6_lookup(struct net *net, struct inet_hashinfo *hashinfo,

			  struct sk_buff *skb, int doff,

			  const struct in6_addr *saddr, const __be16 sport,

			  const struct in6_addr *daddr, const __be16 dport,

			  const int dif);

include/net/inet_hashtables.h

+12 −6
Original line number Diff line number Diff line
@@ -213,6 +213,7 @@ void inet_unhash(struct sock *sk); 


struct sock *__inet_lookup_listener(struct net *net,

				    struct inet_hashinfo *hashinfo,

				    struct sk_buff *skb, int doff,

				    const __be32 saddr, const __be16 sport,

				    const __be32 daddr,

				    const unsigned short hnum,
@@ -220,10 +221,11 @@ struct sock *__inet_lookup_listener(struct net *net, 


static inline struct sock *inet_lookup_listener(struct net *net,

		struct inet_hashinfo *hashinfo,

		struct sk_buff *skb, int doff,

		__be32 saddr, __be16 sport,

		__be32 daddr, __be16 dport, int dif)

{

	return __inet_lookup_listener(net, hashinfo, saddr, sport,

	return __inet_lookup_listener(net, hashinfo, skb, doff, saddr, sport,

				      daddr, ntohs(dport), dif);

}
@@ -299,6 +301,7 @@ static inline struct sock * 


static inline struct sock *__inet_lookup(struct net *net,

					 struct inet_hashinfo *hashinfo,

					 struct sk_buff *skb, int doff,

					 const __be32 saddr, const __be16 sport,

					 const __be32 daddr, const __be16 dport,

					 const int dif)
@@ -307,12 +310,13 @@ static inline struct sock *__inet_lookup(struct net *net, 
	struct sock *sk = __inet_lookup_established(net, hashinfo,

				saddr, sport, daddr, hnum, dif);



	return sk ? : __inet_lookup_listener(net, hashinfo, saddr, sport,

					     daddr, hnum, dif);

	return sk ? : __inet_lookup_listener(net, hashinfo, skb, doff, saddr,

					     sport, daddr, hnum, dif);

}



static inline struct sock *inet_lookup(struct net *net,

				       struct inet_hashinfo *hashinfo,

				       struct sk_buff *skb, int doff,

				       const __be32 saddr, const __be16 sport,

				       const __be32 daddr, const __be16 dport,

				       const int dif)
@@ -320,7 +324,8 @@ static inline struct sock *inet_lookup(struct net *net, 
	struct sock *sk;



	local_bh_disable();

	sk = __inet_lookup(net, hashinfo, saddr, sport, daddr, dport, dif);

	sk = __inet_lookup(net, hashinfo, skb, doff, saddr, sport, daddr,

			   dport, dif);

	local_bh_enable();



	return sk;
@@ -328,6 +333,7 @@ static inline struct sock *inet_lookup(struct net *net, 


static inline struct sock *__inet_lookup_skb(struct inet_hashinfo *hashinfo,

					     struct sk_buff *skb,

					     int doff,

					     const __be16 sport,

					     const __be16 dport)

{
@@ -337,8 +343,8 @@ static inline struct sock *__inet_lookup_skb(struct inet_hashinfo *hashinfo, 
	if (sk)

		return sk;

	else

		return __inet_lookup(dev_net(skb_dst(skb)->dev), hashinfo,

				     iph->saddr, sport,

		return __inet_lookup(dev_net(skb_dst(skb)->dev), hashinfo, skb,

				     doff, iph->saddr, sport,

				     iph->daddr, dport, inet_iif(skb));

}

net/dccp/ipv4.c

+1 −1
Original line number Diff line number Diff line
@@ -802,7 +802,7 @@ static int dccp_v4_rcv(struct sk_buff *skb) 
	}



lookup:

	sk = __inet_lookup_skb(&dccp_hashinfo, skb,

	sk = __inet_lookup_skb(&dccp_hashinfo, skb, __dccp_hdr_len(dh),

			       dh->dccph_sport, dh->dccph_dport);

	if (!sk) {

		dccp_pr_debug("failed to look up flow ID in table and "

net/dccp/ipv6.c

+1 −1
Original line number Diff line number Diff line
@@ -668,7 +668,7 @@ static int dccp_v6_rcv(struct sk_buff *skb) 
		DCCP_SKB_CB(skb)->dccpd_ack_seq = dccp_hdr_ack_seq(skb);



lookup:

	sk = __inet6_lookup_skb(&dccp_hashinfo, skb,

	sk = __inet6_lookup_skb(&dccp_hashinfo, skb, __dccp_hdr_len(dh),

			        dh->dccph_sport, dh->dccph_dport,

				inet6_iif(skb));

	if (!sk) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE