Commit a57d476d authored by Phil Reid's avatar Phil Reid Committed by David S. Miller
Browse files

net: dsa: lan9303: make lan9303_handle_reset() a void function



lan9303_handle_reset never returns anything other than success.
So there's not need for it to return an error code.

Signed-off-by: default avatarPhil Reid <preid@electromag.com.au>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9f239fe6
Loading
Loading
Loading
Loading
+3 −7
Original line number Diff line number Diff line
@@ -817,18 +817,16 @@ static void lan9303_bridge_ports(struct lan9303 *chip)
	lan9303_alr_add_port(chip, eth_stp_addr, 0, true);
}

static int lan9303_handle_reset(struct lan9303 *chip)
static void lan9303_handle_reset(struct lan9303 *chip)
{
	if (!chip->reset_gpio)
		return 0;
		return;

	if (chip->reset_duration != 0)
		msleep(chip->reset_duration);

	/* release (deassert) reset and activate the device */
	gpiod_set_value_cansleep(chip->reset_gpio, 0);

	return 0;
}

/* stop processing packets for all ports */
@@ -1328,9 +1326,7 @@ int lan9303_probe(struct lan9303 *chip, struct device_node *np)

	lan9303_probe_reset_gpio(chip, np);

	ret = lan9303_handle_reset(chip);
	if (ret)
		return ret;
	lan9303_handle_reset(chip);

	ret = lan9303_check_device(chip);
	if (ret)