Commit a57aa93f authored Mar 05, 2014 by Wang YanQing Committed by Tomi Valkeinen Mar 06, 2014

video: fbdev: uvesafb: Remove redundant NULL check in uvesafb_remove



Because uvesafb_par is allocated as part of fb_info in uvesafb_probe,
so we don't need to do NULL check for both fb_info and uvesafb_par in
uvesafb_remove.

[ This patch also fix a warning report by fengguang.wu@intel.com
  "drivers/video/fbdev/uvesafb.c:1815 uvesafb_remove()
   warn: variable dereferenced before check 'par'" ]

Signed-off-by: Wang YanQing <udknight@gmail.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

parent 2925b0d7

drivers/video/uvesafb.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -1812,11 +1812,9 @@ static int uvesafb_remove(struct platform_device *dev)
		fb_destroy_modedb(info->monspecs.modedb);
		fb_dealloc_cmap(&info->cmap);

		if (par) {
		kfree(par->vbe_modes);
		kfree(par->vbe_state_orig);
		kfree(par->vbe_state_saved);
		}

		framebuffer_release(info);
		}

Admin message