Commit a56f992c authored Dec 13, 2012 by Johannes Berg

mac80211: use del_timer_sync for final sta cleanup timer deletion



This is a very old bug, but there's nothing that prevents the
timer from running while the module is being removed when we
only do del_timer() instead of del_timer_sync().

The timer should normally not be running at this point, but
it's not clearly impossible (or we could just remove this.)

Cc: stable@vger.kernel.org
Tested-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 97f97b1f

net/mac80211/sta_info.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -884,7 +884,7 @@ void sta_info_init(struct ieee80211_local *local)

		void sta_info_stop(struct ieee80211_local *local)
		{
		del_timer(&local->sta_cleanup);
		del_timer_sync(&local->sta_cleanup);
		sta_info_flush(local, NULL);
		}

Admin message