Commit a56bc69a authored Sep 14, 2007 by Michael Ellerman Committed by Greg Kroah-Hartman Oct 12, 2007

PCI: Fix incorrect argument order to list_add_tail() in PCI dynamic ID code

The code for dynamically assigning new ids to PCI drivers,
store_new_id(), calls list_add_tail() with the list head and new node
arguments in reversed order.

The result is that every new id written essentially overwrites the
previous list of ids.

Caught with the help of Rusty's "horribly bad" list_node patch:
 http://lkml.org/lkml/2007/6/10/10



Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 5b1ea82f

drivers/pci/pci-driver.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -54,7 +54,6 @@ store_new_id(struct device_driver driver, const char buf, size_t count)
		if (!dynid)
		return -ENOMEM;

		INIT_LIST_HEAD(&dynid->node);
		dynid->id.vendor = vendor;
		dynid->id.device = device;
		dynid->id.subvendor = subvendor;
		@@ -65,7 +64,7 @@ store_new_id(struct device_driver driver, const char buf, size_t count)
		driver_data : 0UL;

		spin_lock(&pdrv->dynids.lock);
		list_add_tail(&pdrv->dynids.list, &dynid->node);
		list_add_tail(&dynid->node, &pdrv->dynids.list);
		spin_unlock(&pdrv->dynids.lock);

		if (get_driver(&pdrv->driver)) {

Admin message