Commit a560c527 authored Jan 16, 2017 by Amelie Delaunay Committed by Alexandre Belloni Jan 23, 2017

rtc: stm32: use 0 instead of ~PWR_CR_DBP in regmap_update_bits



Using the ~ operator on a BIT() constant results in a large 'unsigned long'
constant that won't fit into an 'unsigned int' function argument on 64-bit
architectures, resulting in a harmless build warning in x86 allmodconfig:

drivers/rtc/rtc-stm32.c: In function 'stm32_rtc_probe':
drivers/rtc/rtc-stm32.c:651:51: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
  regmap_update_bits(rtc->dbp, PWR_CR, PWR_CR_DBP, ~PWR_CR_DBP);

As PWR_CR_DBP mask prevents other bits to be cleared, replace all
~PWR_CR_DBP by 0.

Fixes: 4e64350f ("rtc: add STM32 RTC driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

parent 5fa40869

drivers/rtc/rtc-stm32.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -648,7 +648,7 @@ static int stm32_rtc_probe(struct platform_device *pdev)
		err:
		clk_disable_unprepare(rtc->ck_rtc);

		regmap_update_bits(rtc->dbp, PWR_CR, PWR_CR_DBP, ~PWR_CR_DBP);
		regmap_update_bits(rtc->dbp, PWR_CR, PWR_CR_DBP, 0);

		device_init_wakeup(&pdev->dev, false);

		@@ -670,7 +670,7 @@ static int stm32_rtc_remove(struct platform_device *pdev)
		clk_disable_unprepare(rtc->ck_rtc);

		/* Enable backup domain write protection */
		regmap_update_bits(rtc->dbp, PWR_CR, PWR_CR_DBP, ~PWR_CR_DBP);
		regmap_update_bits(rtc->dbp, PWR_CR, PWR_CR_DBP, 0);

		device_init_wakeup(&pdev->dev, false);

Admin message